Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing with engine #3063

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix signing with engine #3063

merged 2 commits into from
Sep 23, 2024

Conversation

DaanDeMeyer
Copy link
Contributor

We need to make sure /run/pcscd/pcscd.comm is available to make
signing work so let's mount /run/pcscd into the sandbox every time
we're going to sign something if it exists.

Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff's not happy about the first commit, otherwise LGTM.

We need to make sure /run/pcscd/pcscd.comm is available to make
signing work so let's mount /run/pcscd into the sandbox every time
we're going to sign something if it exists.
@DaanDeMeyer DaanDeMeyer linked an issue Sep 23, 2024 that may be closed by this pull request
@DaanDeMeyer DaanDeMeyer merged commit 5eab779 into systemd:main Sep 23, 2024
30 of 36 checks passed
@DaanDeMeyer DaanDeMeyer deleted the engine branch September 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can't pass pkcs11 url to sbsign (still)
2 participants