Parse profiles after mkosi.conf.d #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
profile
branch
2 times, most recently
from
eb2c52e
to
b63b819
Compare
|
Added the PR to read mkosi.local on top of this one as it depends on some stuff from the profile one |
DaanDeMeyer
force-pushed
the
profile
branch
from
b63b819
to
e7fcf9b
Compare
behrmann
reviewed
Sep 21, 2024
DaanDeMeyer
force-pushed
the
profile
branch
4 times, most recently
from
c6d38f2
to
fa53ef8
Compare
Currently profiles can't depend on any of the configuration set in mkosi.conf.d as they are parsed before mkosi.conf.d is parsed. Let's parse the profile related configuration last instead so it can match on all the configuration set in mkosi.conf.d. To set the distribution and release and such based on the profile, a dropin in mkosi.conf.d can match on the configured profile instead.
DaanDeMeyer
force-pushed
the
profile
branch
2 times, most recently
from
3a31d5c
to
a65300d
Compare
behrmann
approved these changes
Sep 21, 2024
behrmann
requested changes
Sep 21, 2024
|
LGTM otherwise, but the change from |
behrmann
reviewed
Sep 21, 2024
DaanDeMeyer
force-pushed
the
profile
branch
from
a65300d
to
e2c9450
Compare
For many use cases it's useful to be able to configure more than one profile, an example is selecting a generic desktop profile and a more specific kde profile as well.
DaanDeMeyer
force-pushed
the
profile
branch
from
e2c9450
to
28ea786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently profiles can't depend on any of the configuration set in mkosi.conf.d as they are parsed before mkosi.conf.d is parsed. Let's parse the profile related configuration last instead so it can match on all the configuration set in mkosi.conf.d.
To set the distribution and release and such based on the profile, a dropin in mkosi.conf.d can match on the configured profile instead.