Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is the implementation for the solution, but I'm very conflicted about having a special case for
@page
.It feels bad, doesn't it? Could we maybe... choose a different solution?
There's no perfect solution here, but I suppose I'd rather resign from the
size
shorthand and addw
andh
shorthands in its place.An alternative we could consider — could we just not implement anything?
There's an escape hatch with
css
prop, Safari doesn't support@page
. Seems less correct than dropping thesize
alias, and we'd probably need an error thrown only in development, but it's something 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w/h shorthands will require changes by a significant percentage of Theme UI users & seems like a price they shouldn’t have to pay to me. The number of people using
@page
is likely tiny, & it’s very easy to update what code in the extremely rare case this change breaks it (imagine usages of that selector to find & replace vs “size” in a codebase). This isn’t very correct but it just doesn’t seem like a common issue to be sad about not getting your (screen-optimized) theme as automatically accessible in printing page setup for some browsers.