Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Switch to PortAudio #76

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] Switch to PortAudio #76

wants to merge 3 commits into from
+220 −168

Conversation

Cuda-Chen
Copy link
Contributor

@Cuda-Chen Cuda-Chen commented Feb 23, 2025 •
edited
Loading

Switch to PortAudio for cross-platform and cross backend compatibility.

Yet, there are two known limitations for current sound playback implementation:

  1. The last period of sound is lost.
  2. You cannot play sound twice or the device will crash thus
    whole system crashes.

@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@jserv
Copy link
Collaborator

jserv commented Feb 23, 2025

You should explain the motivation and benefit for the migration of PortAudio.

@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@Cuda-Chen
[WIP] Switch to PortAudio
0d81990 
Switch to PortAudio for cross-platform and cross backend compatibility.

Yet, there are two known limitations for current sound playback implementation:
1. The last period of sound is lost.
2. You cannot play sound twice or the device will crash thus
whole system crashes.
@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@bito-code-review Bito Code Review
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cuda-Chen @jserv