Fix bottom-half processing by transitioning to workqueue #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Feb 17, 2025
There was a problem hiding this comment.
- Read https://cbea.ms/git-commit/ carefully and enforce the rules.
- Append
Close #191at the end of git commit messages.
jserv
changed the title
Based on issue sysprog21#191 (@trulykyle)'s feedback, the original bottomhalf.c example was calling msleep() inside a tasklet, which runs in atomic context and can lead to a kernel crash. This patch moves the time- consuming work to a workqueue, which runs in process context and allows sleeping, while preserving the immediate LED control logic in the ISR. Close sysprog21#191
|
Updated commit message to follow best practices. |
|
Thank @nicehorse06 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #191 by moving the blocking msleep() call from a tasklet (atomic context) to a workqueue (process context).
This change prevents kernel crashes due to sleeping in atomic context, while still preserving the immediate LED control logic in the ISR.
Summary by Bito
This pull request refactors the kernel's bottom-half processing by replacing tasklets with workqueues, resolving issue #191. It prevents kernel crashes from sleeping in atomic context while ensuring immediate LED control in the ISR. Function names have been updated to reflect these changes.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and well-documented, making the review process relatively easy.