feat(metrics): add of temporal and environmental score handling #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2021 15:56
Lutie
changed the title
Lutie
changed the title
resilva
reviewed
Feb 24, 2021
src/score-calculator.ts
Outdated
| // If ModifiedScope is Unchanged 6.42 × MISS | ||
| // If ModifiedScope is Changed 7.52 × (MISS - 0.029) - 3.25 × (MISS × 0.9731 - 0.02)13 | ||
| // ModifiedExploitability = 8.22 × ModifiedAttackVector × ModifiedAttackComplexity × ModifiedPrivilegesRequired × ModifiedUserInteraction | ||
| // Note : Math.pow is 15 in 3.0 but 13 int 3.1 |
Member
There was a problem hiding this comment.
I think there is a typo error with int at the end of the sentence.
resilva
reviewed
Feb 24, 2021
Comment on lines
+12
to
+13
| TemporalMetric, | ||
| temporalMetrics, |
Member
There was a problem hiding this comment.
Maybe think of another name for temporalMetrics it might be difficult to differentiate the two variables in the code with just a plural and case difference.
Author
There was a problem hiding this comment.
environmentalMetricMap would match better i suppose:
EnvironmentalMetric,
environmentalMetricMap,
EnvironmentalMetricValue,
added 9 commits
February 24, 2021 11:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.