Bd 1201 syscoin api resolve security issues #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bartekus
commented
Jul 11, 2018
bartekus
commented
- Separate devDependencies from dependencies
- Update dependencies and devDependencies
- Remove unused lib && fix all vulnerability that affect dependencies
- Add cross-env & refactor npm scripts
jnessbcf
approved these changes
Jul 11, 2018
| "integrated": "APIRUNMODE=integrated node .", | ||
| "windows-isolated": "set APIRUNMODE=isolated&& node .", | ||
| "windows-integrated": "set APIRUNMODE=integrated&& node .", | ||
| "isolated": "cross-env APIRUNMODE=isolated node .", |
There was a problem hiding this comment.
Nice stuff. Needs to be verified by one of the Windows crew (@ShahnawazAli93 , @quangogster , and/or @oshchepkov ) for runnability but I'm glad to see cross-env here.
There was a problem hiding this comment.
Cool, will try this updated script and let you know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.