Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish shell completions #622

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix fish shell completions #622

merged 1 commit into from
Oct 17, 2023

Conversation

synfinatic
Copy link
Owner

Original code didn't work at all and failed to install if the ~/.config/fish/completions/ directory didn't exist

@synfinatic
Copy link
Owner Author

I think this is a better fix than #497.

@synfinatic synfinatic mentioned this pull request Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #622 (55a9693) into main (e893b9f) will increase coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.02%     
==========================================
  Files          35       35              
  Lines        3244     3247       +3     
==========================================
+ Hits         2675     2678       +3     
  Misses        501      501              
  Partials       68       68              
Files Coverage Δ
internal/utils/fileedit.go 73.33% <100.00%> (+0.68%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882ce51...55a9693. Read the comment docs.

@synfinatic synfinatic force-pushed the fix-fish-completions branch 2 times, most recently from 73062e0 to 40aba9e Compare October 17, 2023 01:04
@synfinatic synfinatic added this to the 1.15.0 milestone Oct 17, 2023
@synfinatic synfinatic force-pushed the fix-fish-completions branch 3 times, most recently from 126e7d4 to 1182455 Compare October 17, 2023 01:36
Original code didn't work at all and failed to install
if the ~/.config/fish/completions/ directory didn't exist
@synfinatic synfinatic merged commit ebf0b2b into main Oct 17, 2023
7 checks passed
@synfinatic synfinatic deleted the fix-fish-completions branch October 17, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant