Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash due to go variable context change #1056

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix crash due to go variable context change #1056

merged 1 commit into from
Sep 21, 2024

Conversation

synfinatic
Copy link
Owner

Go v1.22 changes how variables are shadowed which was causing ListAccounts() to return an empty list

Go v1.22 changes how variables are shadowed which was causing
ListAccounts() to return an empty list
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.43%. Comparing base (60c56c4) to head (8687d9e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/sso/awssso.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          35       35           
  Lines        3037     3037           
=======================================
  Hits         2564     2564           
  Misses        380      380           
  Partials       93       93           
Flag Coverage Δ
unittests 84.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/sso/awssso.go 72.49% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c56c4...8687d9e. Read the comment docs.

@synfinatic synfinatic merged commit f055a85 into main Sep 21, 2024
6 of 7 checks passed
@synfinatic synfinatic deleted the fix-crash branch September 21, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant