Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --lines CLI argument #1038

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix --lines CLI argument #1038

merged 2 commits into from
Aug 27, 2024

Conversation

synfinatic
Copy link
Owner

Fixes: #1037

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (09b3c07) to head (c3e9267).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   84.14%   84.43%   +0.30%     
==========================================
  Files          35       35              
  Lines        3038     3037       -1     
==========================================
+ Hits         2556     2564       +8     
+ Misses        389      380       -9     
  Partials       93       93              
Flag Coverage Δ
unittests 84.43% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/logger/logger.go 75.00% <100.00%> (ø)
internal/sso/settings.go 76.70% <100.00%> (-0.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b3c07...c3e9267. Read the comment docs.

@synfinatic synfinatic merged commit 4dba62b into main Aug 27, 2024
7 checks passed
@synfinatic synfinatic deleted the fix-logging branch August 27, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging with --lines is broken
1 participant