Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to console logger by default #1029

Merged
merged 1 commit into from
Aug 20, 2024
Merged

switch to console logger by default #1029

merged 1 commit into from
Aug 20, 2024

Conversation

synfinatic
Copy link
Owner

Refs: #1001

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.00%. Comparing base (ae2a0f4) to head (dedb87f).
Report is 6 commits behind head on main.

Files Patch % Lines
internal/logger/init.go 37.50% 15 Missing ⚠️
cmd/aws-sso/logger.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   51.06%   51.00%   -0.06%     
==========================================
  Files          59       60       +1     
  Lines        4988     5012      +24     
==========================================
+ Hits         2547     2556       +9     
- Misses       2348     2363      +15     
  Partials       93       93              
Flag Coverage Δ
unittests 51.00% <54.29%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.98% <100.00%> (ø)
internal/ecs/http.go 100.00% <100.00%> (ø)
internal/ecs/server/server.go 92.94% <100.00%> (ø)
internal/helper/helper.go 69.61% <100.00%> (ø)
internal/predictor/predictor.go 85.26% <100.00%> (ø)
internal/sso/logger.go 100.00% <100.00%> (ø)
internal/storage/storage.go 96.43% <100.00%> (ø)
internal/tags/logger.go 100.00% <100.00%> (ø)
internal/url/url.go 91.03% <100.00%> (ø)
internal/utils/utils.go 96.12% <100.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2a0f4...dedb87f. Read the comment docs.

@synfinatic synfinatic merged commit d1d8570 into main Aug 20, 2024
5 checks passed
@synfinatic synfinatic deleted the console-logger branch August 20, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant