lib/geoip, cmd/relaypoolsrv, cmd/ursrv: Automatically manage GeoIP updates #9342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: lib/model: Typo in method name (fixes syncthing#9389) lib/model: Typo in debug print (fixes syncthing#9386) build: Update dependencies (syncthing#9379) build(deps): bump actions/cache from 3 to 4 (syncthing#9363) lib/api: Improve folder summary event, verbose service (syncthing#9370) lib/protocol: Refactor interface (syncthing#9375) gui, man, authors: Update docs, translations, and contributors lib/fs: Add invalid UTF-8 guards to watcher (fixes syncthing#9369) (syncthing#9372) lib/api: Remove remnants of CSRF tokens file mentions (ref syncthing#9284) gui, man, authors: Update docs, translations, and contributors gui: Remove non-functional HTML from External Versioning tooltip (ref syncthing#8923) (syncthing#9358) cmd/ursrv: Add FreeBSD detection (syncthing#9351) cmd/ursrv: Fix Arch detection (syncthing#9350) lib/ignore: Optimise ignoring directories for filesystem watcher (fixes syncthing#9339) (syncthing#9340) gui, man, authors: Update docs, translations, and contributors lib/ignore: Refactor out result type (syncthing#9343)
imsodin
reviewed
Feb 2, 2024
lib/geoip/geoip.go
Outdated
| func (p *Provider) open(ctx context.Context) (*geoip2.Reader, error) { | ||
| if p.licenseKey == "" { | ||
| return nil, errors.New("open: no license key set") | ||
| } |
There was a problem hiding this comment.
I don't remember, but I'm surprised this is now mandatory?
gudvinr
reviewed
Feb 7, 2024
* main: lib/logger: Split STTRACE into list of strings (syncthing#9402) gui, man, authors: Update docs, translations, and contributors
* release: build: Use Go 1.22.3 at minimum
* main: (45 commits) build: Use Go 1.22.3 at minimum build: Use Go 1.22.3 at minimum gui: Add Hindi (hi) translation template (syncthing#9530) gui, man, authors: Update docs, translations, and contributors lib/connections: Add syncthing_connections_active metric (fixes syncthing#9527) (syncthing#9528) etc: Use 7MiB buffer size (syncthing#9524) gui: Fix Firefox bookmark favicon (fixes syncthing#9506) (syncthing#9507) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors lib/nat: Don't crash on empty address list (fixes syncthing#9503) (syncthing#9504) lib/db: Drop indexes for outgoing data to force refresh (ref syncthing#9496) (syncthing#9502) gui: Fix missing link to device editor for names with superscript (ref syncthing#9472) (syncthing#9494) lib/db: Hold update lock while taking snapshot (syncthing#9496) build: Update dependencies (syncthing#9497) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors Removed no longer relevant Bountysource link (syncthing#9480) lib/api: Missing return after HTTP error lib/api: Extract session store (syncthing#9425) ...
* main: gui, man, authors: Update docs, translations, and contributors
calmh
changed the title
AudriusButkevicius
approved these changes
May 17, 2024
|
Indeed, but we're the only one running it, and it doesn't look great with the map broken, so 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small package
geoipwhich knows how to download and manage the Maxmind GeoLite2 database we use. This removes the need for various scripts to download and manage the geoip database, something that today happens on Docker startup for the relay pool server and using various hand written hacks for the usage reporting server.The database is downloaded when needed and then refreshed on a best-effort basis weekly.