docs(contributing): describe using conventional commits #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
force-pushed
the
jb/convcommits
branch
from
2a28ba5
to
a16d3d6
Compare
calmh
changed the title
calmh
changed the title
tomasz1986
reviewed
Sep 10, 2024
Co-authored-by: tomasz1986 <[email protected]>
acolomb
reviewed
Sep 10, 2024
|
|
||
| - Commits that resolve an existing issue must include the issue number | ||
| as ``(fixes #123)`` at the end of the commit message subject. A correctly | ||
| formatted commit message looks like this:: | ||
|
|
||
| lib/dialer: Add env var to disable proxy fallback (fixes #3006) | ||
| feat(dialer): add env var to disable proxy fallback (fixes #3006) |
There was a problem hiding this comment.
Thought we wanted to move the "fixes" mention from the subject to the message body?
There was a problem hiding this comment.
I do, in principle, but there was some pushback and we have some scripts that expect it, so I think it can stay for now.
Co-authored-by: André Colomb <[email protected]>
imsodin
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy change.