Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users/contrib: Point to newer Syncthing-GTK fork #873

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

Rikiub
Copy link
Contributor

@Rikiub Rikiub commented Aug 8, 2024

@Rikiub Rikiub changed the title Update and rename contrib.rst to Add Syncthing GTK Fork Add Syncthing GTK Fork to Community Contributions Aug 8, 2024
@acolomb
Copy link
Member

acolomb commented Aug 8, 2024

Your renaming of the file will not work.

Please file a proper patch against the existing file. Ideally, you would only add a remark to the section where Syncthing-GTK is already mentioned. Pointing to the new and old URL might be better for people to recognize the software.

@Rikiub
Copy link
Contributor Author

Rikiub commented Aug 9, 2024

Ideally, you would only add a remark to the section where Syncthing-GTK is already mentioned

Don't make sense because it's already in Older, Possibly Unmaintained section. The purpose of this PR is revive the project, so make sense add it again to "Linux" section.

I don't understand, need I add something like "This is a fork of the old project " on the description?
I would like keep things simple.

@imsodin
Copy link
Member

imsodin commented Aug 9, 2024

The new one doesn't look very maintained, last activity is a year ago. Seems like it never actually took off. So maybe just add the link and leave it in the unmaintained section.

@Rikiub
Copy link
Contributor Author

Rikiub commented Aug 9, 2024

It makes sense.
I move and replace it to "Unmaintained" section.

Hope the project get up.

@acolomb
Copy link
Member

acolomb commented Aug 9, 2024

You really need to stop renaming files. Whatever you do while working on the PR, it leads to the file being renamed matching your commit message. Don't do that, please.

users/Add from where was forked Outdated Show resolved Hide resolved
Rikiub and others added 2 commits August 9, 2024 15:47
@Rikiub
Copy link
Contributor Author

Rikiub commented Aug 9, 2024

You really need to stop renaming files. Whatever you do while working on the PR, it leads to the file being renamed matching your commit message. Don't do that, please.

Sorry, I not notice it in the first commit.
Now should be ok.

@acolomb acolomb changed the title Add Syncthing GTK Fork to Community Contributions users/contrib: Point to newer Syncthing-GTK fork Aug 12, 2024
@acolomb acolomb added this pull request to the merge queue Aug 12, 2024
Merged via the queue into syncthing:main with commit 7c14485 Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants