[Toolkit] WIP: [Bootstrap] Add Bootstrap 5#3463
Conversation
|
Hello, that's great, a new kit! To start with a quick overview, here are two small points:
Bonus and purely personal opinion: for interactive elements like collapse, rather than using data attributes, I think it might be more efficient to use a stimulus controller that then uses a Bootstrap object (e.g., new bootstrap.Collapse(collapseEl)). |
|
Thanks for the feedback @DcgRG, I tried to address those |
|
|
||
| connect() { | ||
| this._collapse = new Collapse(this.contentTarget, { | ||
| toggle: false, |
There was a problem hiding this comment.
You can add "parent" option here
|
Ultimately, is an Accordion component simply a group of Collapse elements? Nope ? |
|
Indeed, the accordion is a map of collapse. I removed the accordion controller. It's just a little bit confusing to have things like |
Add bootstrap 5.3 kit with multiple components. There is still more components to do but I think it's worth having feedback before I continue. For disclosure, I used Claude Opus 4.6 to help me.