Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-static PHPUnit assert methods #20405

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Use non-static PHPUnit assert methods #20405

merged 1 commit into from
Nov 25, 2024
+9 −9

Conversation

javiereguiluz
Copy link
Member

Fixes #20392.

@javiereguiluz javiereguiluz added this to the 6.4 milestone Nov 22, 2024
@javiereguiluz javiereguiluz mentioned this pull request Nov 22, 2024
Closed
xabbuh
xabbuh requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are some more examples in /components.clock.rst

@wouterj wouterj requested a review from xabbuh November 22, 2024 21:15
@javiereguiluz javiereguiluz merged commit 421f42c into symfony:6.4 Nov 25, 2024
3 checks passed
@javiereguiluz javiereguiluz deleted the fix_20392 branch November 25, 2024 07:38
@javiereguiluz
Copy link
Member Author

@OskarStark do you know if DOCtor-RST can alert if we use self::assert* instead of $this->assert*? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @wouterj @xabbuh @carsonbot