Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* layers/+lang/python/packages.el: Fix importmagic leak #16381

Merged
merged 1 commit into from May 11, 2024

Conversation

sunlin7
Copy link
Contributor

@sunlin7 sunlin7 commented May 1, 2024

Hi,

There is a serious resource leak when enable python layer with importmage package enabled.
The reproduce steps are:

  1. enable python layer, and the imortmagic should also be instralled for its python layer dependency.
  2. open a python source code,
  3. start python interpreter
  4. execute python-shell-send-buffer or other send function.
  5. execute list-processes to show the process
    You will see every time execute the step 4, the epc:server in process list will increaced.
    The reason is the emacs-29 had enhanced implementation for with-temp-buffer which won't call the kill-buffer-hook while the importmagic-mode will create epc:server on mode hook and stop the epc:server on kill-buffer-hook but it won't be called for temp buffer.
    This change will fix the issue with avoiding starting the epc:server for temp buffer.

Please help review and merge the patch. Thanks

@smile13241324
Copy link
Collaborator

Thanks for fixing this :)

@smile13241324 smile13241324 merged commit ca8b995 into syl20bnr:develop May 11, 2024
7 of 8 checks passed
@sunlin7
Copy link
Contributor Author

sunlin7 commented May 13, 2024

@smile13241324 Thank goodness you're back!

@smile13241324
Copy link
Collaborator

No worries ;), I just need some breaks from time to time you know surgeries and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants