* layers/+lang/python/packages.el: Fix importmagic leak #16381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a serious resource leak when enable
python
layer withimportmage
package enabled.The reproduce steps are:
python
layer, and theimortmagic
should also be instralled for its python layer dependency.python-shell-send-buffer
or other send function.list-processes
to show the processYou will see every time execute the step 4, the
epc:server
in process list will increaced.The reason is the emacs-29 had enhanced implementation for
with-temp-buffer
which won't call thekill-buffer-hook
while theimportmagic-mode
will createepc:server
on mode hook and stop theepc:server
onkill-buffer-hook
but it won't be called for temp buffer.This change will fix the issue with avoiding starting the
epc:server
for temp buffer.Please help review and merge the patch. Thanks