Enhance the eshell with its built-in ansi-color support #16377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* layers/+tools/shell/packages.el: Bump the xterm-color package for * emacs < 29.0.50. * layers/+tools/shell/README.org: Document for the changes.
smile13241324
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The Eshell works with ansi-color on both Emacs-29 and Emacs-30, don't bother the
xterm-colorpackage.So move the the xterm-color initialization code to its initialization function.
This patch will let the Eshell works with most terminal tools colorful, for example, these command lines will work great in the eshell:
$ /bin/ls --color=tty
$ /bin/git status # with git config color.ui always
Please help review the changes. Thanks.