[spacemacs-editing-visual] Disable vhl occur extension in Emacs 28+ #16367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension causes an error when navigating to occur matches starting in Emacs 29, and already in Emacs 28, it became unnecessary since occur does its own highlighting of matches when you visit them. See k-talo/volatile-highlights.el#26.
|
vhl seems quite abandoned. Protesilaos' Pulsar seems a more modern, well-maintained alternative used elsewhere (eg. goggles.el). |
smile13241324
approved these changes
May 11, 2024
|
Possible but I am unsure if its worth the effort as emacs 28 and later do not need it at all |
bcc32
added a commit
to janestreet/spacemacs
that referenced
this pull request
May 21, 2024
This is a cherry-pick of syl20bnr#16367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension causes an error when navigating to occur matches
starting in Emacs 29, and already in Emacs 28, it became unnecessary
since occur does its own highlighting of matches when you visit them.
See k-talo/volatile-highlights.el#26.