New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers/+spacemacs/spacemacs-purpose: move to define-advice #16360

Merged

smile13241324 merged 1 commit into syl20bnr:develop from sunlin7:fix-spacemacs-purpose

May 11, 2024

Contributor

sunlin7 commented Apr 5, 2024

Hi,
I got warning messages on startup for defadvice, so move to the define-advice.

layers/+spacemacs/spacemacs-purpose/packages.el: Warning: ‘defadvice’ is an obsolete macro (as of 30.1); use ‘advice-add’ or ‘define-advice’

Please help review the changes, thanks.


layers/+spacemacs/spacemacs-purpose: move to define-advice

046031c

smile13241324 approved these changes

View reviewed changes

smile13241324 merged commit 1ce1b0e into syl20bnr:develop

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment