fix smartparens-mode inserts double ' in minibuffer #16353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartparens-mode is sometimes activated in the minibuffer by spacemacs//conditionally-enable-smartparens-mode, specifically if we are in the minibuffer due to eval-expression (or eldoc-eval-expression). This is convenient for things like parens, but we don't want this behavior on a single quote. It looks like we *tried* to stop this, but for whatever reason that configuration was for minibuffer-inactive-mode rather than minibuffer-mode. The former is the major mode of the minibuffer when it is *not* active, whereas the latter is the major mode of the minibuffer when it *is* active. This has been part of spacemacs for a long time, so I've simply added configuration for minibuffer-mode and left behind the configuration for minibuffer-inactive-mode in case somebody was relying on that
dankessler
force-pushed
the
minibuffer-sp-fix
branch
from
29cde1f
to
e8a3232
Compare
smile13241324
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smartparens-mode is sometimes activated in the minibuffer by spacemacs//conditionally-enable-smartparens-mode, specifically if we are in the minibuffer due to eval-expression (or eldoc-eval-expression). This is convenient for things like parens, but we don't want this behavior on a single quote. It looks like we tried to stop this, but for whatever reason that configuration was for minibuffer-inactive-mode rather than minibuffer-mode. The former is the major mode of the minibuffer when it is not active, whereas the latter is the major mode of the minibuffer when it is active. This has been part of spacemacs for a long time, so I've simply added configuration for minibuffer-mode and left behind the configuration for minibuffer-inactive-mode in case somebody was relying on that