2.9.4 release

sybrew · Aug 30, 2017 · 8b01c99 · 8b01c99 · earcos · Aug 31, 2017
1 parent c263aea
commit 8b01c99
Show file tree

Hide file tree

Showing 4 changed files with 288 additions and 291 deletions.
diff --git a/autodescription.php b/autodescription.php
@@ -3,7 +3,7 @@
  * Plugin Name: The SEO Framework
  * Plugin URI: https://theseoframework.com/
  * Description: An automated, advanced, accessible, unbranded and extremely fast SEO solution for any WordPress website.
- * Version: 2.9.4-dev-2017.08.28.4
+ * Version: 2.9.4
  * Author: Sybre Waaijer
  * Author URI: https://theseoframework.com/
  * License: GPLv3
@@ -51,7 +51,7 @@
  *
  * @since 1.0.0
  */
-define( 'THE_SEO_FRAMEWORK_VERSION', '2.9.3' );
+define( 'THE_SEO_FRAMEWORK_VERSION', '2.9.4' );
 
 /**
  * The plugin Database version.

diff --git a/inc/classes/generate-url.class.php b/inc/classes/generate-url.class.php
@@ -778,15 +778,21 @@ public function get_shortlink( $post_id = 0 ) {
 
 		$additions = '';
 		if ( ! empty( $query ) ) {
-
 			if ( false !== strpos( $query, '&' ) ) {
+				//= This can fail on malformed URLs
 				$query = explode( '&', $query );
 			} else {
 				$query = array( $query );
 			}
 
 			foreach ( $query as $arg ) {
-				if ( false === strpos( $path, $arg ) )
+				/**
+				 * @since 2.9.4 Added $args availability check.
+				 * This is a band-aid, not a fix.
+				 * @TODO inspect prior explode().
+				 * @link https://wordpress.org/support/topic/error-when-previewing-a-draft-of-knowledge-base-article/#post-9452791
+				 */
+				if ( $arg && false === strpos( $path, $arg ) )
 					$additions .= '&' . $arg;
 			}
 		}