feat: owner user and group linemode #932
Conversation
| @@ -21,6 +21,8 @@ function Folder:linemode(area, files) | |||
| spans[#spans + 1] = ui.Span(time and os.date("%y-%m-%d %H:%M", time // 1) or "") | |||
| elseif mode == "permissions" then | |||
| spans[#spans + 1] = ui.Span(f.cha:permissions() or "") | |||
| elseif mode == "owner" then | |||
| spans[#spans + 1] = ui.Span(f.cha:owner() or "") | |||
There was a problem hiding this comment.
Please use the existing user_name() instead, https://yazi-rs.github.io/docs/plugins/utils#ya.user_name
|
Made suggested change |
sxyazi
force-pushed
the
main
branch
10 times, most recently
from
b98d00e
to
c65a14c
Compare
| @@ -21,6 +21,12 @@ function Folder:linemode(area, files) | |||
| spans[#spans + 1] = ui.Span(time and os.date("%y-%m-%d %H:%M", time // 1) or "") | |||
| elseif mode == "permissions" then | |||
| spans[#spans + 1] = ui.Span(f.cha:permissions() or "") | |||
| elseif mode == "owner" then | |||
| local username = ya.user_name(f.cha.uid) | |||
There was a problem hiding this comment.
ya.user_name, ya.group_name, cha.uid, and cha.gid are Unix-specific attributes/methods, they will break the UI rendering on the Windows platform.
Perhaps we can expose them to the Windows platform, but just return a nil value? Or add this code snippet to the Tips page so Unix users can copy it from there? Curious your thoughts!
There was a problem hiding this comment.
I think it is pretty important on Unix to be able to see the user and group of files by default. Additionally this functionality somewhat already exists through the status bar.
It would be nice if this functionality could work on Windows as well. It looks doable here, but more complicated than it should be.
If we expose these methods to the Windows platform we should remove the ability to see the ownership key-bind in the help page. It would be confusing for a Windows user to see the option and have it do nothing.
I am happy to implement either safely hiding it on Windows or having the ownership functionality on Windows, up to you.
There was a problem hiding this comment.
Great, please implement the ownership functionality on Windows!
|
I'm going to close this because it still needs some work and hasn't seen any activity recently. @AidanV thanks for the effort! |
|
Sounds good, I do not have access to a Windows computer at the moment. I will pick it back up when I do. |
Added m => o linemode keymap that displays the user and group of the owner of a file or directory.
Adds dependency in yazi-shared
users = "0.11.0"
https://crates.io/crates/users