Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6: in.h extended #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ipv6: in.h extended #640

wants to merge 1 commit into from

Conversation

XITRIX
Copy link
Contributor

@XITRIX XITRIX commented Feb 20, 2024

To be able to use MDNS lib I had to add header for ipv6 address structure

@WinterMute
Copy link
Contributor

fwiw the switch network stack doesn't support ipv6 so there isn't really much point in dns providing ipv6 addresses. You might be better off looking at making ipv6 support optional in that lib instead.

@XITRIX
Copy link
Contributor Author

XITRIX commented Feb 21, 2024

Yes, it does not support it, but in terms of portability and maintainability I'd prefer to be able to compile non modified version of library, than forking it and doing any modifications just for Switch. I'm making cross platform app, so it will be a really painful if I'll need to do it for each platform like this, than just add missing headers and allow it to build without any problems

@WinterMute
Copy link
Contributor

WinterMute commented Feb 21, 2024

Yes, it does not support it, but in terms of portability and maintainability I'd prefer to be able to compile non modified version of library, than forking it and doing any modifications just for Switch. I'm making cross platform app, so it will be a really painful if I'll need to do it for each platform like this, than just add missing headers and allow it to build without any problems

The switch isn't the only system around which doesn't support ipv6. It would seem reasonable to upstream a patch there to allow building without ipv6 support. That would be my recommended option here rather than adding things to libnx headers.

@XITRIX
Copy link
Contributor Author

XITRIX commented Feb 21, 2024

Maybe you are right, I just saw some structures for ipv6 already presented in switch headers, and this was the only one missing to be able to successfully compile and run this lib for Switch, but I just checked the solution for this lib on PSVita, and as you said, they forked this library and added IPV6_UNSUPPORTED definition for vita around ipv6 related functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants