fix(docs): fix custom element registry conflicts by renaming list-components with unique names #5356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents with unique names
🦋 Changeset detectedLatest commit: 556279c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Related Previews |
leagrdv
requested changes
Apr 29, 2025
| @@ -22,8 +22,8 @@ interface IndexInput { | |||
| }; | |||
| } | |||
|
|
|||
| @customElement('list-component') | |||
| export class ListComponent extends LitElement { | |||
| @customElement('designer-list-component') | |||
There was a problem hiding this comment.
It's still calling list-component in the developer.docs.mdx and designer.docs.mdx files, shouldn't it be updated there as well?
github-project-automation
bot
moved this from 👀 Triage
to 🧐 In Review
in Design System Production Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
Fixed rendering issue in the Getting Started category by solving component name conflicts between Designer and Developer pages.
The issue was caused by identical custom element names ("list-component") being registered twice in the Storybook environment, resulting in the error: "Failed to execute 'define' on 'CustomElementRegistry': the name 'list-component' has already been used with this registry".
The solution:
🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
📝 Checklist