Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow phpstan 2 #1

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Allow phpstan 2 #1

merged 1 commit into from
Jan 31, 2025

Conversation

bbrala
Copy link
Member

@bbrala bbrala commented Jan 29, 2025

Description

phpstan 2

@JaZo JaZo self-requested a review January 30, 2025 12:37
JaZo
JaZo requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@JaZo JaZo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran an inspection on a real world project and it did create a report, but that report didn't contain all errors. I'll try to find the issue!

JaZo
JaZo approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@JaZo JaZo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the issue and it's unrelated to this PR!

Client error: PUT http://api.bitbucket.org/2.0/repositories/... resulted in a 400 Bad Request response: {"key": "report-service.general.bad-request", "message": "The summary field cannot contain more than 450 characters.", " (truncated...)

@JaZo JaZo merged commit b34d859 into main Jan 31, 2025
@JaZo JaZo deleted the feature/phpstan-2 branch January 31, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaZo JaZo JaZo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrala @JaZo