Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable mousewheel directive when zoom is disabled #541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alesbrelih
Copy link

This allows to normally scroll through page when zoom is disabled.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

When zoom is disabled you can't use mouse wheel to scroll to the bottom of page if mouse is over the ngx-graph component.

What is the new behavior?

If zoom is disabled you can normally use your mouse wheel to scroll.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This allows to normally scroll through page when zoom is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant