Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Addition of safe code when accessing this._rowDiffer #2170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcmojave
Copy link

@marcmojave marcmojave commented Jan 4, 2024

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)**
A Kibana error logged on behalf of our saas platform with the error: this._rowDiffer is undefined.

What is the new behavior?
Added some safe code to prevent this error.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
n/a

Other information:

gx-datatable version: 20.0.0
Angular version: 13.3.11

Additional info from Kibana log

{
  "_index": "admin-v2-2023.10.30",
  "_type": "doc",
  "_id": "LMNMgosBRe6EzFrlioq2",
  "_version": 1,
  "_score": null,
  "_source": {
    "timestamp": "Oct 30 20:35:33",
    "severity_label": "Error",
    "type": "php_messages",
    "data_center": "whk1",
    "program": "ADMIN-V2",
    "@timestamp": "2023-10-30T20:35:33.000Z",
    "priority": 155,
    "data": {
      "errorType": "generic",
      "user": "wiflix_net",
      "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0",
      "name": "TypeError",
      "stack": {
        "lineNumber": 1,
        "fileName": "https://admin.adnation.com/main.d1e04289377265dd.js",
        "functionName": "value",
        "source": "value@https://admin.adnation.com/main.d1e04289377265dd.js:1:4989379",
        "columnNumber": 4989379
      },
      "body": null,
      "detailErrMsg": null,
      "status": null,
      "id": "ADMIN-V2-1698698131715",
      "appId": "ADMIN-V2",
      "errMsg": "this._rowDiffer is undefined",
      "appVersion": "3.439.3",
      "payload": "",
      "time": 1698698131715
    },
    "severity": 3,
    "facility_label": "local3",
    "facility": 19,
    "host": "127.0.0.1",
    "logstash_processed": "true",
    "pid": "5033",
    "logsource": "exo-whk1-sweb1.isprime.com",
    "@version": "1"
  },
  "fields": {
    "@timestamp": [
      "2023-10-30T20:35:33.000Z"
    ]
  },
  "highlight": {
    "logsource.keyword": [
      "@[email protected]@/kibana-highlighted-field@"
    ]
  },
  "sort": [
    1698698133000
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant