OpaqueValues: borrow accessor support#90561
Draft
kavon wants to merge 2 commits into
Draft
Conversation
We don't change the result of a SILFunctionType based on whether we've lowered addresses for address-only types. For those, we provide only the "formal" convention answers corresponding to the post-AddressLowering state. This refactoring gets `isAddressResult` and its friends that were added for borrow accessors to be aligned with that design pattern. For callers at a stage prior to AddressLowering, they should be relying on SILFunctionConventions instead.
This set of changes adds some of the missing support for borrow/inout accessors to SILGen and AddressLowering. rdar://180980139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD