[SIL] Fix non_abi functions missing [serialized] in SILFunctionBuilder#90532
Open
AlexsanderDamaceno wants to merge 1 commit into
Open
[SIL] Fix non_abi functions missing [serialized] in SILFunctionBuilder#90532AlexsanderDamaceno wants to merge 1 commit into
AlexsanderDamaceno wants to merge 1 commit into
Conversation
AlexsanderDamaceno
force-pushed
the
sil-fix-non-abi-serialized
branch
from
01a4627 to
876aa1b
Compare
getDefinitionLinkage() and getSerializedKind() can disagree for @export(implementation): linkage becomes PublicNonABI but serialized kind is IsNotSerialized because getSerializedKind() caps effective access to internal when the enclosing type is not public, returning early without considering the linkage. Add a consistency check in getOrCreateFunction() that forces [serialized] on any PublicNonABI/PackageNonABI function, covering both the new-function and HiddenExternal-promotion paths.
AlexsanderDamaceno
force-pushed
the
sil-fix-non-abi-serialized
branch
from
876aa1b to
8d4232a
Compare
Contributor
Author
|
@eeckstein @jckarter could take a look at this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug analysis:
getDefinitionLinkage()andgetSerializedKind()can disagree for@export(implementation)linkage becomes PublicNonABI but serialized kind is IsNotSerialized becausegetSerializedKind()caps effective access to internal when the enclosing type is not public, returning early without considering the linkage.Solution in this patch:
Add a consistency check in
getOrCreateFunction()that forces [serialized] on any PublicNonABI/PackageNonABI functionFilled bug: #90225