[cxx-interop] Fix crash when specializing a templated SubscriptDecl#89276
Draft
j-hui wants to merge 1 commit into
Draft
[cxx-interop] Fix crash when specializing a templated SubscriptDecl#89276j-hui wants to merge 1 commit into
j-hui wants to merge 1 commit into
Conversation
rewriteIntegerTypes unwrapped the outer (Self) -> ... curry layer for any instance member, constructor, or static decl. SubscriptDecl interface types are not curried this way (they are already (Args) -> Element), so the strip overshot into the bare element type and the subsequent getParams() dereferenced garbage. Gate the unwrap on hasImplicitSelfDecl(), which is the precise condition for having an outer Self curry layer. rdar://177482177
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewriteIntegerTypes unwrapped the outer (Self) -> ... curry layer for any instance member, constructor, or static decl. SubscriptDecl interface types are not curried this way (they are already (Args) -> Element), so the strip overshot into the bare element type and the subsequent getParams() dereferenced garbage.
Gate the unwrap on hasImplicitSelfDecl(), which is the precise condition for having an outer Self curry layer.
rdar://177482177