[cxx-interop] Allow function template instantiations with optional foreign reference types#89265
Open
patrykstefanski wants to merge 1 commit into
Conversation
…reign reference types `convertTemplateArgument` only handled `Optional<*Pointer<T>>` types via `classifyPointer()`. For `Optional<FRT>`, it returned an empty QualType, failing the template instantiation. Add a case that converts `Optional<FRT>` to `FRT* _Nullable`, mirroring how the non-optional path produces `FRT* _Nonnull` via `convertClangDecl`. rdar://177206923
patrykstefanski
requested review from
Xazax-hun,
egorzhdan,
hnrklssn,
j-hui and
susmonteiro
as code owners
patrykstefanski
requested review from
hamishknight,
hborla,
slavapestov and
xedin
as code owners
hnrklssn
reviewed
May 20, 2026
| // function re-imports with an optional return type. Otherwise, it would | ||
| // be re-imported as non-optional FRT. | ||
| if (argType->isForeignReferenceType()) { | ||
| return withCache([&]() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertTemplateArgumentonly handledOptional<*Pointer<T>>types viaclassifyPointer(). ForOptional<FRT>, it returned an empty QualType, failing the template instantiation. Add a case that convertsOptional<FRT>toFRT* _Nullable, mirroring how the non-optional path producesFRT* _NonnullviaconvertClangDecl.rdar://177206923