[stdlib, 6.4.x] Add missing conformances to Ref and MutableRef#89262
Open
glessard wants to merge 3 commits into
Open
[stdlib, 6.4.x] Add missing conformances to Ref and MutableRef#89262glessard wants to merge 3 commits into
glessard wants to merge 3 commits into
Conversation
glessard
added
🍒 release cherry pick
Contributor
Author
|
@swift-ci please test |
glessard
force-pushed
the
rdar177198190-ref-mutableref-conformances-6.4.x
branch
from
ef632e7 to
277baa1
Compare
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
SE-0519 introduced
RefandMutableRef, which are in essence a single-element version ofSpanandMutableSpan. They should have the same protocol conformances asSpanandMutableSpan, and we add them here.The proposal was amended here, and accepted here.
Scope:
Adds conformances to
RefandMutableReffor marker protocols (without ABI impact).Issues:
Addresses rdar://177198190
Original PRs:
[stdlib] Add missing conformances to Ref and MutableRef #89188
Risk:
Low. Allows strictly more code to compile, with no ABI impact.
Testing:
Added tests for the conformances.
Reviewers:
@Azoy