Eliminate Unnecessary alloc_pack instructions#89260
Draft
aidan-hall wants to merge 7 commits into
Draft
Conversation
aidan-hall
force-pushed
the
pack-opt-simplify-alloc-pack
branch
from
f3973cd to
27c3bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an
alloc_packpack only contains concrete elements, and every access is at a known, scalar index, replace it with multiplealloc_stackinstructions, one for each element. This unlocks further optimisations, in passes like SILMem2Reg and DeadObjectElimination.Fixes: