SourceKit: Remove CloseClangModuleFiles#89256
Open
AnthonyLatsis wants to merge 1 commit into
Open
Conversation
Comment says to remove this thing when the radar is resolved, which was a long time ago. Try to rip it out to avoid a rebranch-specific change.
Collaborator
Author
|
@swift-ci please test |
benlangmuir
approved these changes
May 19, 2026
Contributor
benlangmuir
left a comment
benlangmuir
left a comment
There was a problem hiding this comment.
The changes we made for rdar://19720334 and the many changes since then in that area likely fixed this, though it's hard to be 100% sure. As long as we don't see any regressions it makes sense to me to try deleting it. If nothing else we will learn if there is a remaining issue that needs fixing in clang.
Contributor
|
@swift-ci please test |
hamishknight
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment says to remove this thing when the radar is resolved, which was a long time ago. Try to rip it out to avoid a rebranch-specific change.