Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark readme with info on how to ensure benchmarks test locally built stdlib #79528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iThinker
Copy link

I recently tried to run modify stdlib and run benchmarks, but I had issues with it, and readme was not helpful enough.
This PR adds a bit of info to readme to help future readers.

Problems addressed:

  1. Building standalone benchmarks fails when using standard xcode toolchains. In my case error looked like - error: cannot find '_wordIndex' in scope.
  2. I could not make benchmarks use locally built stdlib. Even though this readme says they should use ../lib/swift. So the two env variables helped me solve the problem.

Special thanks to @Catfish-Man for helping with these.

@iThinker iThinker requested a review from eeckstein as a code owner February 20, 2025 21:26
@eeckstein
Copy link
Contributor

eeckstein commented Feb 21, 2025

The easiest way to run the benchmarks - actually: compare two benchmark builds - is to use the scripts/run_smoke_bench script. This is unfortunately also not documented.
This script e.g. takes care of setting DYLD_LIBRARY_PATH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants