TSCTestSupport: avoid dropping path components#323
Open
compnerd wants to merge 1 commit into
Open
Conversation
Given that the `AbsolutePath` constructor invoked here is `AbsolutePath(_:relativeTo:)` dropping the first component is not meaningful for UNIX paths as an absolute path relative to root is going be the same path as the path relative to the root being re-formed to be relative to the root. However, this meaningfully impacts paths on Windows as the shared path representation currently does not include the drive or server & share (in the UNC case) and the resulting absolute path representation is a drive-relative path, where dropping the first component alters the path representation.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
Member
Author
|
@swift-ci please test |
Contributor
|
done have tests to make sure this still works correctly on all platforms? |
Member
Author
|
The tools-support-core tests don't work on Windows (I'm tempted to spend the necessary energy towards removing the dependency). The SPM tests will definitely exercise this heavily, and the assertion in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the
AbsolutePathconstructor invoked here isAbsolutePath(_:relativeTo:)dropping the first component is notmeaningful for UNIX paths as an absolute path relative to root is going
be the same path as the path relative to the root being re-formed to be
relative to the root. However, this meaningfully impacts paths on
Windows as the shared path representation currently does not include the
drive or server & share (in the UNC case) and the resulting absolute
path representation is a drive-relative path, where dropping the first
component alters the path representation.