Add an SPI Attachment.uncheckedPreferredName property.
#1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a for-tools SPI property `uncheckedPreferredName` to `Attachment`. We can then use this property to distinguish when the developer provided or did not provide a name for an attachment. Tools can then use this property and apply their own naming rules when consuming attachments from the event stream. Naming is hard; I'm open to other/better names.
grynspan
requested review from
briancroom,
stmontgomery and
suzannaratcliff
as code owners
grynspan
added
tools integration
|
Actually never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a for-tools SPI property
uncheckedPreferredNametoAttachment. We can then use this property to distinguish when the developer provided or did not provide a name for an attachment.Tools can then use this property and apply their own naming rules when consuming attachments from the event stream.
Naming is hard; I'm open to other/better names.
Checklist: