Skip to content

Add @_preInverseGenerics to Attachment: CustomStringConvertible. #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Add @_preInverseGenerics to Attachment: CustomStringConvertible. #1378

merged 1 commit into from
Oct 24, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 24, 2025 •
edited
Loading

To avoid a crash in Xcode 26, we need Attachment's conformance to CustomStringConvertible to not take ~Copyable into account. Yay.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Add @_preInverseGenerics to Attachment: CustomStringConvertible.
e2e98f8 
To avoid a crash in Xcode 26, we need `Attachment`'s conformance to
`CustomStringConvertible` to not take `~Copyable` into account. Yay.
@grynspan grynspan added this to the Swift 6.x (main) milestone Oct 24, 2025
@grynspan grynspan self-assigned this Oct 24, 2025
@grynspan grynspan added tools integration 🛠️ Integration of swift-testing into tools/IDEs workaround Workaround for an issue in another component (may need to revert later) attachments/activities 🖇️ Work related to attachments and/or activities labels Oct 24, 2025
@grynspan grynspan merged commit 4889f15 into main Oct 24, 2025
26 checks passed
@grynspan grynspan deleted the jgrynspan/attachments-preinversegenerics branch October 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels

attachments/activities 🖇️ Work related to attachments and/or activities tools integration 🛠️ Integration of swift-testing into tools/IDEs workaround Workaround for an issue in another component (may need to revert later)

Projects

None yet

Milestone

Swift 6.x (main)

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan @stmontgomery