Build AddCompletionHandler body as CodeBlockSyntax#3336
Open
broken-circle wants to merge 1 commit into
Open
Conversation
`CodeBlockSyntax` now conforms to `SyntaxExpressibleByStringInterpolation`, so build the synthesized function body directly as a `CodeBlockSyntax` literal rather than parsing an `ExprSyntax` and wrapping it.
broken-circle
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AddCompletionHandlerpeer macro inPeerMacroTestshad a FIXME noting thatCodeBlockSyntaxshould be madeExpressibleByStringInterpolationso the synthesized function body could be written directly. That conformance exists today, so this PR resolves the FIXME by building the body as aCodeBlockSyntaxliteral and assigning it directly, instead of parsing anExprSyntaxand wrapping it viaCodeBlockSyntax { newBody }.