Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1] Fix an infinite loop if a conflict marker is found but it's not at the start of a new line #2901

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 20, 2024

  • Explanation: The parser would enter into an infinite loop when a closing conflict marker was not at the start of a line. Until I found the underlying issue, I was looking at performance issues with conflict marker lexing and was able to improve the parsing time of a file consisting of only conflict markers by 2x (not that it matters much in practice but doesn’t hurt either). That’s included in a second commit.
  • Scope: Lexing of conflict markers
  • Risk: Low
  • Testing: Added a test case / manually tested performance of conflict marker parsing
  • Issue: rdar://137746823
  • Reviewer: @DougGregor @rintaro on Fix an infinite loop if a conflict marker is found but it's not at the start of a new line #2899

@ahoppen ahoppen requested a review from bnbarham as a code owner November 20, 2024 20:52
@ahoppen
Copy link
Member Author

ahoppen commented Nov 20, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 0f622c8 into swiftlang:main Dec 4, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.1/conflict-marker-infinite-loop branch December 4, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants