experimental-build-server should provide compiler arguments for header files#9903
Merged
owenv merged 1 commit intoswiftlang:mainfrom Apr 9, 2026
Merged
experimental-build-server should provide compiler arguments for header files#9903owenv merged 1 commit intoswiftlang:mainfrom
owenv merged 1 commit intoswiftlang:mainfrom
Conversation
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is equivalent to the one in SourceKit-LSP for the native build system - It attempts to find a C-family source file in the same target as the header and modify its args to compile the header directly. This lives in SwiftPM instead of Swift Build because package headers aren't currently represented in the PIF, so we need to add them at this level instead.