Open
Conversation
…wiftPM (swiftlang#9883)" This reverts commit 35fd89a.
package manifest directly, and then walks the resulting syntax tree to find the package declaration, its targets, dependencies, and so on. For anything in the syntax tree that the parsing manifest loader does not recognize, it records a "limitation" associated with that syntax tree node. The presence of any limitations means that the result of the parsing manifest loader should not be trusted, in which case we can fall back to the existing manifest loader. One can request that the limitations, if found, are printed to the terminal using the experimental flag --experimental-show-manifest-parser-limitations. This can be used to determine why a particular package manifest isn't handled by the parsing manifest loader. We could use this information to expand the capabilities of the parsing manifest loader in the future, so that more manifests would benefit from it as a fast path. The parsing manifest loader takes advantage of the SwiftIfConfig library to handle #if in the package manifest. It queries the compiler frontend to determine the configuration of the compiler that would be used to build the manifest so we get the same results from #if. Additionally, the parsing manifest loader maintains a static version of the Context that is available to the package manifest, so it can substitute (e.g.) the package directory, Git information, or environment information into the package manifest. The large amount of churn in the package loading tests are because most of the tests have been switched from just using the existing manifest loader to iterating over both loaders (using forEachManifestLoader). This ensures that both loaders pass the same set of tests. Additionally, we check that the resulting manifests from both loaders matches exactly (by encoding them into JSON) to ensure that the results are the same. This way, we can keep the manifest loaders in sync for the subset of package manifests that are meant to work. This also adds an experimental command-line option, --experimental-manifest-processing-mode, that enables the parsing manifest loader. It must be provided with one of the following options: - only-parsed: only use the parsing loader. This is not correct, because manifests can require execution, but can be used for testing. - only-executed: only using the executing loader, which is the normal one. This is the default for now. - parsed-with-fallback: try using the parsing loader. If it encounters limitations, fall back to the executing loader without failing. This option is what can provide build-time performance improvements when the parsing manifest loader takes over. - crosscheck: try both the parsing and the executing loaders and compare the results to ensure they match. If the parsing loader encounters limitations, no further checking will be done. On success, it will print the relative times. If the results differ, it will print the JSON form of the manifest from each parser.
The loop at the end was silly. Keep track of where the condition is so we can parse it later.
DougGregor
requested review from
AnthonyLatsis,
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
xedin
as code owners
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci build toolchain |
Member
Author
|
@swift-ci please test macOS |
The host library path contains the shared libraries against which the various tools in the toolchain are built, which means the host compiler---not the runtime library path for the platform.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please smoke test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #9759 but reverting #9883