Fix OutputHandler.print method API#9683
Open
bripeticca wants to merge 6 commits intoswiftlang:mainfrom
Open
Conversation
bripeticca
requested review from
bkhouri,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
clearer condition API for the print method introduced, making it easier to deduce whether the text should be emitted depending on the verbosity level.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Feb 4, 2026
bkhouri
reviewed
Feb 4, 2026
bkhouri
requested changes
Feb 4, 2026
Contributor
bkhouri
left a comment
bkhouri
left a comment
There was a problem hiding this comment.
I had a couple blocking comments .
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conditionin the form of an enum (OutputCondition) to clarify that this parameter serves to check whether the output should be printed depending on if thelogLevelis verbose.