jextract: Indirect returns and more value type support #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-value-type-fixes
branch
from
44cc1e3 to
5dff5e8
Compare
ktoso
commented
Jan 27, 2025
| @@ -73,6 +74,34 @@ public enum NominalTypeKind { | |||
| case `class` | |||
| case `enum` | |||
| case `struct` | |||
| case `void` // TODO: NOT NOMINAL, BUT... | |||
There was a problem hiding this comment.
I'll work on removing this NominalTypeKind so we replace it with SwiftNominalTypeDeclaration.Kind but we'll have to do a bit of a dance to pull it off -- perhaps make it optional somehow or enum over "nominal or not nominal" etc
ktoso
commented
Jan 27, 2025
| @@ -44,18 +44,19 @@ public struct ImportedNominalType: ImportedDecl { | |||
| TranslatedType( | |||
| cCompatibleConvention: .direct, | |||
| originalSwiftType: "\(raw: swiftTypeName)", | |||
| originalSwiftTypeKind: self.kind, | |||
There was a problem hiding this comment.
TODO: we'll want to remove this and instead pass around a SwiftNominalTypeDeclaration instead, and base the name and kind off from that.
ktoso
changed the title
ktoso
force-pushed
the
wip-value-type-fixes
branch
from
5dff5e8 to
d4b26a9
Compare
ktoso
commented
Jan 27, 2025
| @@ -274,6 +294,15 @@ enum CCompatibleJavaMemoryLayout: Hashable { | |||
| case cFunction | |||
| } | |||
|
|
|||
| enum SwiftTypeKind { | |||
There was a problem hiding this comment.
TODO: Working on removing this and converge with the other SwiftNominalTypeDeclaration.Kind in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes: