Benchmarks: default to local swift-foundation branch#1981
Open
itingliu wants to merge 2 commits into
Open
Conversation
With no environment variable set, benchmarks now build against the local swift-foundation branch with other package dependencies fetched from remote. Previously the default was the system Foundation / toolchain, which is rarely useful for everyday work at desk. USE_TOOLCHAIN=1 opts back in to the old default (Foundation.framework on macOS, toolchain Foundation on Linux). Adds Benchmarks/README.md documenting prerequisites, run commands, and all four configurations (local default, SWIFTCI_USE_LOCAL_DEPS, USE_PACKAGE, USE_TOOLCHAIN). Condenses the Benchmarks section in Foundation_Build_Process.md to a pointer to that README.
itingliu
force-pushed
the
benchmark-local-benchmark
branch
from
9870784 to
70acaaf
Compare
Contributor
Author
|
@swift-ci please test |
itingliu
commented
May 15, 2026
| case .useLocalPackage(let root), .useLocalPackageRemoteDeps(let root): | ||
| #if os(macOS) | ||
| packageDependency.append(.package(name: "foundation-local", path: "\(root)/swift-foundation")) | ||
| targetDependency.append(.product(name: "FoundationEssentials", package: "foundation-local")) |
Contributor
Author
There was a problem hiding this comment.
This foundation-local is set at the main Package.swift. Its value depends on whether SWIFTCI_USE_LOCAL_DEPS is set. When it is set it's using local check, and remote one if unset.
Contributor
|
There are 2 obstacles to how
To solve both, maybe we can figure out a way to avoid re-exporting the packages through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no environment variable set, benchmarks now build against the local swift-foundation branch with other package dependencies fetched from remote. Previously the default was the system Foundation / toolchain, which is rarely useful for everyday work at desk.
USE_TOOLCHAIN=1 opts back in to the old default (Foundation.framework on macOS, toolchain Foundation on Linux).
Adds Benchmarks/README.md documenting prerequisites, run commands, and all four configurations (local default, SWIFTCI_USE_LOCAL_DEPS, USE_PACKAGE, USE_TOOLCHAIN). Condenses the Benchmarks section in Foundation_Build_Process.md to a pointer to that README.