Skip to content

Prevent decimal_withFormat_localeDependent from relying on the current locale #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent decimal_withFormat_localeDependent from relying on the current locale #1428

wants to merge 1 commit into from

Conversation

jmschonfeld
Copy link
Contributor

Updates this unit test to avoid relying on the current locale so that it won't fail if the locale changes to non-en_US in the middle of the test

@jmschonfeld jmschonfeld requested a review from itingliu July 11, 2025 23:37
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

itingliu
itingliu approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was going to clean these up too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itingliu itingliu itingliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmschonfeld @itingliu