Add visionOS support#844
Open
yonihemi wants to merge 2 commits into
Open
Conversation
Kyle-Ye
reviewed
Dec 3, 2024
Contributor
Kyle-Ye
left a comment
Kyle-Ye
left a comment
There was a problem hiding this comment.
LGTM in general.
But I'm not sure if we need to add visionOS support since we do not have support for watchOS/tvOS/etc.
Can you point out some use case on why we need to run swift-docc on iOS / visionOS platform since those platform does not support running executable target directly?
Only macOS / Linux / Windows support running cli executable.
cc @franklinsch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for running DocC on visionOS by extending platform checks.
Dependencies
Upgrades Swift Crypto to v2.6.0, which removed specific os conditions.
Testing
Run
SwiftDocCTestsandSwiftDocCUtilitiesTestswith a visionOS simulator target.No platform-specific tests added.
I don't think there's a public way to run the benchmark for a target other than host.