Variant dylibs should have unsuffixed install names - #1545
Open
ndrewh wants to merge 2 commits into
Open
Conversation
ndrewh
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
owenv,
rconnell9 and
rjmansfield
as code owners
July 15, 2026 22:00
ndrewh
commented
Jul 15, 2026
| EXECUTABLE_PREFIX = ""; | ||
| EXECUTABLE_SUFFIX = ""; | ||
| EXECUTABLE_NAME = "$(EXECUTABLE_PREFIX)$(PRODUCT_NAME)$(EXECUTABLE_VARIANT_SUFFIX)$(EXECUTABLE_SUFFIX)"; | ||
| EXECUTABLE_INSTALL_NAME = "$(EXECUTABLE_PREFIX)$(PRODUCT_NAME)$(EXECUTABLE_SUFFIX)"; |
Contributor
Author
There was a problem hiding this comment.
I am open to suggestions for a better name.
jakepetroules
left a comment
jakepetroules
left a comment
Collaborator
There was a problem hiding this comment.
This seems right to me. Are frameworks already working correctly today?
jakepetroules
previously approved these changes
Jul 24, 2026
Variant dylibs (i.e. built using BUILD_VARIANTS) should have the same install name as the normal variant. This (among other things) prevents dyld from ever loading both the variant and the original dylib. rdar://79156379
ndrewh
force-pushed
the
variant-install-names
branch
from
July 27, 2026 16:55
5ff60d1 to
c37a6a7
Compare
Contributor
Author
|
@swift-ci test |
ndrewh
commented
Jul 28, 2026
Contributor
Author
|
@swift-ci test |
owenv
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant dylibs (i.e. built using BUILD_VARIANTS) should have the same install name as the original. This (among other things) prevents dyld from ever loading both the variant and the original dylib.
rdar://79156379