Open
Conversation
owenv
reviewed
Mar 26, 2026
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
b015d0b to
e8a5172
Compare
bkhouri
commented
Apr 2, 2026
Contributor
Author
There was a problem hiding this comment.
chore (blocking): revert changes to this file
Contributor
Author
There was a problem hiding this comment.
chore (blocking): Revert changes to this file.
Contributor
Author
There was a problem hiding this comment.
chore (blocking): revert changes to this file
bkhouri
commented
Apr 2, 2026
| if scope.evaluate(BuiltinMacros.ENABLE_ADDRESS_SANITIZER) | ||
| || scope.evaluate(BuiltinMacros.ENABLE_THREAD_SANITIZER) | ||
| || scope.evaluate(BuiltinMacros.ENABLE_UNDEFINED_BEHAVIOR_SANITIZER) | ||
| || scope.evaluate(BuiltinMacros.ENABLE_MEMORY_TAGGING_ADDRESS_SANITIZER) |
Contributor
Author
There was a problem hiding this comment.
should we revert this change, or add ENABLED_SCUDO_SANITIZER here?
Suggested change
| || scope.evaluate(BuiltinMacros.ENABLE_MEMORY_TAGGING_ADDRESS_SANITIZER) | |
| || scope.evaluate(BuiltinMacros.ENABLE_MEMORY_TAGGING_ADDRESS_SANITIZER) | |
| || scope.evaluate(BuiltinMacros.ENABLE_SCUDO_SANITIZER) |
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
e8a5172 to
1ac8fb7
Compare
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 2, 2026
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
1ac8fb7 to
6806d05
Compare
Contributor
Author
|
@swift-ci test |
bkhouri
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
6806d05 to
3158317
Compare
Contributor
Author
|
@swift-ci test |
owenv
reviewed
Apr 7, 2026
| }; | ||
| AdditionalLinkerArgs = { | ||
| YES = ( | ||
| "$(LD_SCUDO_SANITIZER)", |
Collaborator
There was a problem hiding this comment.
LD_SCUDO_SANITIZER is a boolean setting so I think this will add YES to the link command line in addition to the actual flags
Contributor
Author
There was a problem hiding this comment.
Right. Would "$($(LINKER_DRIVER)_LD_SCUDO_SANITIZER)" work in this case?
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
3158317 to
2b7c1af
Compare
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
2b7c1af to
777d4fa
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
777d4fa to
e52d8a7
Compare
Contributor
Author
|
@swift-ci test |
Add support for Scudo sanitizer. Fixes swiftlang#866
bkhouri
force-pushed
the
t/main/gh886_add_scudo_sanitizer_support
branch
from
e52d8a7 to
c5a7d0a
Compare
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Scudo sanitizer.
Fixes #886
Linked PR: swiftlang/swift-package-manager#9904